HA: [lld] r254105 - Reapply r254098.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 26 12:01:45 PST 2015


>On Thu, Nov 26, 2015 at 11:14 AM, George Rimar <grimar at accesssoftek.com<mailto:grimar at accesssoftek.com>> wrote:
>>If it helps, I'll make it a post-commit review request: please change this to auto because of the subtleties here.
>>
>>Was this caught by a buildbot with Clang's warning, or due to a test failing on a machine where size_t != unsigned?
>>
>>- Dave
>
>If failed due to build bot`s error where size_t != unsigned I guess. My msvs/32x config compiled fine that place.
>
>OK - I think we have a warning for this too, but maybe it hasn't been rolled out. Not sure. (cc'd Richard Trieu who implemented/worked on the warning, to see what the status is)
>
>But yeah, especially if this actually introduced a bug (not just a compiler warning), I'd really prefer auto here. These sort of mistakes are pretty easy.

Ok, r254175.



More information about the llvm-commits mailing list