[PATCH] D14983: Introduce new @llvm.getdynamicareaoffset.i{32, 64} intrinsic.

[hfinkel@anl.gov via llvm-commits]

hfinkel added inline comments.

================
Comment at: docs/LangRef.rst:9373
@@ +9372,3 @@
+      complicated, because substracting this value from stack pointer would get the address
+      for upper bound of recent dynamic alloca.
+
----------------
  For targets where stack grows upwards, the situation is a bit more
  complicated, because substracting this value from stack pointer would get the address
  one past the end of the most-recent dynamic alloca.

================
Comment at: docs/LangRef.rst:9379
@@ +9378,3 @@
+
+      Return value type of :ref:`llvm.getdynamicareaoffset <int_getdynamicareaoffset>`
+      must match generic address space's (address-space-0) pointer type for given target,
----------------
The return value type

================
Comment at: docs/LangRef.rst:9380
@@ +9379,3 @@
+      Return value type of :ref:`llvm.getdynamicareaoffset <int_getdynamicareaoffset>`
+      must match generic address space's (address-space-0) pointer type for given target,
+      otherwise LLVM would issue an error on the lowering stage.
----------------
address-space-0 -> remove dashes (not needed because it is not a compound adjective as you have it here).

================
Comment at: docs/LangRef.rst:9383
@@ +9382,3 @@
+
+      Warning: So far it known to work on selected architectures (ARM, AArch64, PowerPC,
+      PowerPC64, x86 and x86_64) where stack grows downwards.
----------------
I'd remove this. You can add "Not supported on all targets" if you'd like, but given that zero is a reasonable default, I'm not sure how much value that adds.


http://reviews.llvm.org/D14983