HA: [lld] r254105 - Reapply r254098.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 23:52:59 PST 2015


>>
>> Author: grimar
>> Date: Wed Nov 25 16:15:01 2015
>> New Revision: 254105
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=254105&view=rev
>> Log:
>> Reapply r254098.
>
>It's helpful to include the original commit message when recommitting a patch so it stands alone/is informative.
Sorry, I focused on fix part and missed that. Next time will do.

>>
>> Fix is (OutputSections.cpp):
>> for (std::pair<const SymbolBody *, size_t> &I : Entries) {
>>  =>
>> for (std::pair<const SymbolBody *, unsigned> &I : Entries) {
>
>It might be best to use 'auto' to avoid this bug

Yes, but that one passed the review and I didnt wanted to touch it a lot because of that. Was not sure about auto here, tried to make minimal changes just to fix the buildbot.



More information about the llvm-commits mailing list