[llvm] r254075 - [WebAssembly] Codegen support for ISD::ExternalSymbol

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 09:52:38 PST 2015


On Wed, Nov 25, 2015 at 8:44 AM, Dan Gohman via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: djg
> Date: Wed Nov 25 10:44:29 2015
> New Revision: 254075
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254075&view=rev
> Log:
> [WebAssembly] Codegen support for ISD::ExternalSymbol
>
> Modified:
>     llvm/trunk/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
>     llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrInfo.td
>     llvm/trunk/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp
>     llvm/trunk/lib/Target/WebAssembly/WebAssemblyMCInstLower.h
>     llvm/trunk/test/CodeGen/WebAssembly/global.ll

[...]

> @@ -433,6 +436,16 @@ SDValue WebAssemblyTargetLowering::Lower
>                       DAG.getTargetGlobalAddress(GA->getGlobal(), DL, VT));
>  }
>
> +SDValue WebAssemblyTargetLowering::LowerExternalSymbol(SDValue Op,
> +                                                       SelectionDAG &DAG) const {

WebAssemblyTargetLowering::LowerExternalSymbol wasn't declared in
WebAssemblyISelLowering.h at this point, causing this to not compile:
http://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/3493/steps/gclient%20runhooks/logs/stdio

I now see this got fixed in r254076.


More information about the llvm-commits mailing list