[PATCH] D14975: MC: Simplify handling of temporary symbols in COFF writer.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 18:58:46 PST 2015


pcc created this revision.
pcc added reviewers: rnk, majnemer, rafael.
pcc added a subscriber: llvm-commits.

The COFF object writer was previously adding unnecessary symbols to its
temporary data structures and cleaning them up later. This made the code
harder to understand and caused a bug (aliases classed as temporary symbols
would cause an assertion failure). A much simpler way of handling such
symbols is to ask the layout for their section-relative position when needed.

Tested with a bootstrap on Windows and by building Chrome.

http://reviews.llvm.org/D14975

Files:
  lib/MC/WinCOFFObjectWriter.cpp
  test/MC/COFF/temporary-alias.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14975.41104.patch
Type: text/x-patch
Size: 7605 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151125/137d2077/attachment-0001.bin>


More information about the llvm-commits mailing list