[PATCH] D14948: [X86] Use precise CFI for pushes by default

[David Kreitzer via llvm-commits]

DavidKreitzer added a comment.

Just a few minor comments, Michael.  Otherwise, I think this looks good.

-Dave


================
Comment at: include/llvm/CodeGen/MachineModuleInfo.h:170
@@ +169,3 @@
+  /// information. False if we only need CFA to be precise at call sites.
+  bool UsePreciseUnwindInfo;
+
----------------
It might be a good idea to add the main points of our discussion to this comment:

- that synchronous (i.e. non-precise) unwind info should be enabled under some yet-to-be-defined switch
- that we would first need the ability to simultaneously emit a synchronous .eh_frame and precise .debug_frame under that switch


================
Comment at: include/llvm/CodeGen/MachineModuleInfo.h:243
@@ -242,1 +242,3 @@
+  bool usePreciseUnwindInfo() const { return UsePreciseUnwindInfo; }
+  bool setUsePreciseUnwindInfo(bool b) { UsePreciseUnwindInfo = b; }
 
----------------
This should return void, right?

================
Comment at: test/CodeGen/X86/push-cfi.ll:12
@@ -13,1 +11,3 @@
+; .cfi_adjust_cfa_offset after each push.
+; Darwin should not generate pushes in eeither circumstance.
 ; CHECK-LABEL: test1_nofp:
----------------
typo "eeither"


http://reviews.llvm.org/D14948