[PATCH] D14889: sancov -not-covered-functions.

[Ivan Krasin via llvm-commits]

krasin added inline comments.

================
Comment at: tools/sancov/sancov.cc:166
@@ +165,3 @@
+    auto InliningInfo = Symbolizer.symbolizeInlinedCode(ClBinaryName, Addr);
+    FailIfError(InliningInfo);
+    for (uint32_t i = 0; i < InliningInfo->getNumberOfFrames(); ++i) {
----------------
Can you please give me examples of that in llvm tools?

================
Comment at: tools/sancov/sancov.cc:276
@@ +275,3 @@
+    ArrayRef<uint8_t> Bytes(reinterpret_cast<const uint8_t *>(BytesStr.data()),
+                            BytesStr.size());
+
----------------
No I don't. Please, at least, add a comment that the code was stolen from objdump. Please, give a more precise location, so that it would be possible to lookup later for a reader that is not you or me.

================
Comment at: tools/sancov/sancov.cc:361
@@ -99,3 +360,3 @@
  public:
   // Read single file coverage data.
   static ErrorOr<std::unique_ptr<CoverageData>> read(std::string FileName) {
----------------
I also think that it's not the right feature. If we want strip prefixes, that should be a flag that specifies the prefix, not auto-magic.


http://reviews.llvm.org/D14889