[PATCH] D14889: sancov -not-covered-functions.

[Alexey Samsonov via llvm-commits]

samsonov added inline comments.

================
Comment at: lib/Object/ObjectFile.cpp:118
@@ +117,3 @@
+
+Triple ObjectFile::getTriple() const {
+  llvm::Triple TheTriple("unknown-unknown-unknown");
----------------
Yeah, let's copy the code, and remove the cases we don't really support yet (MachO/COFF).

================
Comment at: tools/sancov/sancov.cc:487
@@ -266,2 +486,2 @@
   }
 }
----------------
See http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations
Also, it serves as an annotation that you're not supposed to exit from switch.


http://reviews.llvm.org/D14889