[llvm] r253968 - Fix non-PIC build after 253959

Pavel Labath via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 01:46:01 PST 2015


Author: labath
Date: Tue Nov 24 03:46:01 2015
New Revision: 253968

URL: http://llvm.org/viewvc/llvm-project?rev=253968&view=rev
Log:
Fix non-PIC build after 253959

CMAKE_EXE_LINKER_FLAGS is a string. Appending a flag using list(APPEND) introduces an extra
semicolon which breaks stuff. Change this to append the value in the same way that everyone else
seems to be doing.

Modified:
    llvm/trunk/cmake/config-ix.cmake

Modified: llvm/trunk/cmake/config-ix.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/config-ix.cmake?rev=253968&r1=253967&r2=253968&view=diff
==============================================================================
--- llvm/trunk/cmake/config-ix.cmake (original)
+++ llvm/trunk/cmake/config-ix.cmake Tue Nov 24 03:46:01 2015
@@ -301,7 +301,7 @@ else()
   set(ENABLE_PIC 0)
   check_cxx_compiler_flag("-fno-pie" SUPPORTS_NO_PIE_FLAG)
   if(SUPPORTS_NO_PIE_FLAG)
-    list(APPEND CMAKE_EXE_LINKER_FLAGS "-fno-pie")
+    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fno-pie")
   endif()
 endif()
 




More information about the llvm-commits mailing list