[PATCH] D14866: [zorg] Add support for uploading artifacts to the 'llvmlab bisect' bucket and enable this for clang-cmake-mips.

[Daniel Sanders via llvm-commits]

dsanders added a comment.

In http://reviews.llvm.org/D14866#295170, @gkistanova wrote:

> Could you consider subclassing and creating a separate build factory for this kind of builders instead


I'm not sure what you mean by subclassing in this context since it's a plain function. I can duplicate the function or split it into separate stage1/stage2 parts and add the upload between stage1+stage2 if that helps.

> since you do not expect all the existing builders upload to the Google Cloud Storage, please?


When Chris announced the bisection tool (http://lists.llvm.org/pipermail/llvm-dev/2015-October/091140.html) he invited other bot owners to upload to this area so it may turn out that others are interested too. I haven't asked around though.

> The current getClangCMakeBuildFactory is consistent with the build performance data collection and analyses. With the uploading steps it wouldn't be any more. I prefer having a separate build factory for this case.


I'm not sure I understand this. Adding an upload step doesn't prevent the collection of data in the (optional) lnt step as far as I can tell. Am I missing something?

> Thanks for working on this!

> 

> Thanks

> 

> Galina





================
Comment at: zorg/buildbot/builders/ClangBuilder.py:554
@@ -547,1 +553,3 @@
+        env['BOTO_CONFIG'] = boto_config_file
+
     # Set up VS environment, if appropriate.
----------------
gkistanova wrote:
> Please define this as a builder env from the beginning, without introducing a new builder param.
> 
Sure


http://reviews.llvm.org/D14866