[PATCH] D14921: [sanitizer] Don't use ARM_VFPREGS_SIZE for old kernels.

Maxim Ostapenko via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 10:13:24 PST 2015


m.ostepenko added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.cc:127
@@ +126,3 @@
+#   if !defined(ARM_VFPREGS_SIZE)
+#     define ARM_VFPREGS_SIZE (32 * 8 /*fpregs*/ + 4 /*fpscr*/)
+#   endif
----------------
ygribov wrote:
> Perhaps also assert equality in #else branch?
I can do it, but I'll need to move ARM_VFPREGS_SIZE definition down in source code to be able use ASan internal checks (such as COMPILER_CHECK), perhaps just before its usage. Is it OK?


Repository:
  rL LLVM

http://reviews.llvm.org/D14921





More information about the llvm-commits mailing list