[PATCH] D14866: [zorg] Add support for uploading artifacts to the 'llvmlab bisect' bucket and enable this for clang-cmake-mips.

Galina via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 10:12:49 PST 2015


gkistanova added a comment.

Could you consider subclassing and creating a separate build factory for this kind of builders instead, since you do not expect all the existing builders upload to the Google Cloud Storage, please?

The current getClangCMakeBuildFactory is consistent with the build performance data collection and analyses. With the uploading steps it wouldn't be any more. I prefer having a separate build factory for this case.
Thanks for working on this!

Thanks

Galina


================
Comment at: zorg/buildbot/builders/ClangBuilder.py:554
@@ -547,1 +553,3 @@
+        env['BOTO_CONFIG'] = boto_config_file
+
     # Set up VS environment, if appropriate.
----------------
Please define this as a builder env from the beginning, without introducing a new builder param.



http://reviews.llvm.org/D14866





More information about the llvm-commits mailing list