[PATCH] D14893: [llvm-profdata] Change instr prof counter overflow to saturate rather than discard

David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 09:20:47 PST 2015


davidxl added inline comments.

================
Comment at: lib/ProfileData/InstrProfWriter.cpp:118
@@ -115,4 +117,3 @@
     instrprof_error MergeResult = Dest.merge(I);
-    if (MergeResult != instrprof_error::success) {
-      return MergeResult;
-    }
+    if (Result == instrprof_error::success)
+      Result = MergeResult;
----------------
This line does not look right. Is it needed?


http://reviews.llvm.org/D14893





More information about the llvm-commits mailing list