[PATCH] D14918: [tsan] Fix CallocOverflow unit test on OS X

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 07:17:24 PST 2015


dvyukov added a comment.

> Sure, I'll update the patch. (I thought user_calloc is more consistent with the rest of this file, which uses user_alloc and user_free.)


Then, you can submit it as is.

The story behind these tests is somewhat moot. We used them when output tests did not exist. Ideally, they are rewritten to output tests. For output tests the idea is clear: write what user will write, test what matters for user.


http://reviews.llvm.org/D14918





More information about the llvm-commits mailing list