[PATCH] D14894: [PGO] Add --text-format option for llvm-profdata show|merge commands

[Diego Novillo via llvm-commits]

dnovillo added inline comments.

================
Comment at: lib/ProfileData/InstrProfWriter.cpp:188
@@ -174,1 +187,3 @@
+}
+
 std::unique_ptr<MemoryBuffer> InstrProfWriter::writeBuffer() {
----------------
I would move this functionality into lib/ProfileData itself.  See how the sample writers are organized.  From llvm-profdata, you can then just select the kind of writer to use.

================
Comment at: tools/llvm-profdata/llvm-profdata.cpp:280
@@ -254,2 +279,3 @@
   }
+
   if (Reader->hasError())
----------------
Some of the changes in here seem unrelated to the text format changes.  Could you send them separately?


http://reviews.llvm.org/D14894