[PATCH] D14762: X86-FMA3: Memory folding for scalar loads + FMA3

[Vyacheslav Klochkov via llvm-commits]

v_klochkov added a comment.

Hi David,

Thank you for the quick code-review. Excuse me for the delay - I am traveling these days.
I fixed the misprints and updated the unit test.

Thank you,
Slava


================
Comment at: llvm/test/CodeGen/X86/fma-scalar-memfold.ll:5
@@ +4,3 @@
+
+declare <4 x float> @llvm.x86.fma.vfmadd.ss(<4 x float>, <4 x float>, <4 x float>) #3
+declare <4 x float> @llvm.x86.fma.vfmsub.ss(<4 x float>, <4 x float>, <4 x float>) #3
----------------
DavidKreitzer wrote:
> "#3" is not defined.
Fixed.

================
Comment at: llvm/test/CodeGen/X86/fma-scalar-memfold.ll:2
@@ +1,3 @@
+; RUN: llc < %s -mtriple=x86_64-pc-win32 -mcpu=core-avx2 | FileCheck %s
+
+attributes #0 = { nounwind }
----------------
I replaced xmm0 with a variable as you recommended.

Regarding the BB#0 label. Due to some unknown reasons the script update_llc_test_checks.py does not work when I run it, but that script usually generates "CHECK:      # BB#0:" line (I noticed that in other people's change-sets fixing tests with help of that script). So, to relax the test checks a little bit I replaced CHECK-NEXT with CHECK (i.e. it ma be ok to have another label between func entry and # BB#0, which happens on some targets if not use { nounwind }).
Please let me know if it looks good now.


http://reviews.llvm.org/D14762