[PATCH] D14907: [tsan] Fix weakly imported functions on OS X

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 22 23:18:50 PST 2015


dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

LGTM with nit


================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:120
@@ -119,2 +119,3 @@
 #define INTERFACE_ATTRIBUTE SANITIZER_INTERFACE_ATTRIBUTE
-#define WEAK SANITIZER_WEAK_ATTRIBUTE
+#define SANITIZER_WEAK_DEFAULT_IMPL \
+  extern "C" SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE NOINLINE
----------------
also remove CPP_WEAK macro in tsan_defs.h 
it was defined to WEAK



http://reviews.llvm.org/D14907





More information about the llvm-commits mailing list