[PATCH] D14878: findDeadCallerSavedReg needs to pay attention to calling convention

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 22 10:46:43 PST 2015


majnemer added inline comments.

================
Comment at: lib/Target/X86/X86FrameLowering.cpp:160-163
@@ -159,6 +157,1 @@
-
-  static const uint16_t CallerSavedRegs64Bit[] = {
-    X86::RAX, X86::RDX, X86::RCX, X86::RSI, X86::RDI,
-    X86::R8,  X86::R9,  X86::R10, X86::R11, 0
-  };
 
----------------
`getPointerRegClass` will return `GR64_TC` which differs from `CallerSavedRegs64Bit` in that it doesn't include `R10` but does include `RIP`.  I reckon that `GR64_TC` is wrong and should match `CallerSavedRegs64Bit`, what do you think?


Repository:
  rL LLVM

http://reviews.llvm.org/D14878





More information about the llvm-commits mailing list