[PATCH] D14897: [X86] Fix several issues related to X86's psadbw instruction.

Cong Hou via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 21 08:19:49 PST 2015


congh added a comment.

In http://reviews.llvm.org/D14897#294562, @RKSimon wrote:

> Thanks for looking at this! Any idea why there is so much commutation in the tests?


I think probably it is because I marked this operation as commutable?


================
Comment at: lib/Target/X86/X86InstrSSE.td:4096
@@ -4101,1 +4095,3 @@
+defm PSADBW : PDI_binop_rm2<0xF6, "psadbw", X86psadbw, v2i64, v16i8, VR128,
+                            loadv2i64, i128mem, SSE_INTALU_ITINS_P, 1>;
 
----------------
RKSimon wrote:
> Shouldn't loadv2i64 be memopv2i64?
I just copied the following several lines for VPMULUDQ and replaced some strings. I think they are similar, and I am new to this language. I will update it to memopv2i64 if you think this makes more sense.


http://reviews.llvm.org/D14897





More information about the llvm-commits mailing list