[PATCH] D14892: Add Windows error code and tidy formatting for system errors

Paul Robinson via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 20 15:51:54 PST 2015


probinson created this revision.
probinson added reviewers: aaron.ballman, rnk.
probinson added a subscriber: llvm-commits.

In MakeErrMsg, the Windows error text was being pasted directly at the
end of the provided prefix, and only some callers provided appropriate
punctuation. Add the punctuation in MakeErrMsg and remove it from callers.
Also append the actual Windows error code, which can be really useful.


http://reviews.llvm.org/D14892

Files:
  lib/Support/Windows/DynamicLibrary.inc
  lib/Support/Windows/Memory.inc
  lib/Support/Windows/Program.inc
  lib/Support/Windows/WindowsSupport.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14892.40838.patch
Type: text/x-patch
Size: 3896 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151120/55287a4b/attachment.bin>


More information about the llvm-commits mailing list