[PATCH] D14470: [asan] Fix the deadlocks introduced by "On OS X, log reports to syslog and os_trace" commit

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 20 09:51:01 PST 2015


samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

LGTM with a nit. Thanks!


================
Comment at: lib/sanitizer_common/sanitizer_common.h:320
@@ -314,1 +319,3 @@
+                                      bool raw_report = false);
+void NORETURN RawReportMmapFailureAndDie();
 
----------------
You can remove this function from the header, and make it static in .cc file (if not inline it).


http://reviews.llvm.org/D14470





More information about the llvm-commits mailing list