[PATCH] D14845: [Support] Fix SaturatingMultiply<T>() to never cause overflow, Re-enable Unit Tests

Richard Smith via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 20 09:27:02 PST 2015


http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151116/314379.html
On Nov 19, 2015 10:03 PM, "Xinliang David Li" <davidxl at google.com> wrote:

> Link to the other thread?
>
> thanks,
>
> David
>
> On Thu, Nov 19, 2015 at 7:27 PM, Richard Smith <richard at metafoo.co.uk>
> wrote:
>
>> See the patch I posted on the other thread for this issue -- that should
>> avoid the UB and the division in all cases.
>> On Nov 19, 2015 5:55 PM, "David Li via llvm-commits" <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>> davidxl accepted this revision.
>>> davidxl added a comment.
>>> This revision is now accepted and ready to land.
>>>
>>> If you have time, finding a way to speed up the method will be welcome
>>> (such as the fast path suggestion).
>>>
>>>
>>> http://reviews.llvm.org/D14845
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151120/f9153cb1/attachment.html>


More information about the llvm-commits mailing list