[PATCH] D14792: Have 'optnone' respect -fast-isel=false

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 18:15:41 PST 2015


Just make it an enum ala FloatABI with a Default, SelectionDAG, FastISel
and use that everywhere?

-eric

On Thu, Nov 19, 2015 at 5:59 PM Paul Robinson <
Paul_Robinson at playstation.sony.com> wrote:

> probinson added inline comments.
>
> ================
> Comment at: include/llvm/Target/TargetMachine.h:105
> @@ -104,2 +104,3 @@
>    unsigned RequireStructuredCFG : 1;
> +  unsigned OptnoneUsesFastISel : 1;
>
> ----------------
> echristo wrote:
> > No need for this.
> This is where LLVMTargetMachine records the state of the -fast-isel
> command-line option, which SelectionDAGISel needs.  SelectionDAGISel does
> not have direct access to the EnableFastISelOption flag.
>
> Unless you're now saying 'optnone' must always use FastISel? That wasn't
> the conclusion in the llvm-dev thread.
>
>
> http://reviews.llvm.org/D14792
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151120/d28e15a2/attachment.html>


More information about the llvm-commits mailing list