[PATCH] D14831: [ELF/AArch64] Accept -m aarch64linux.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 17:46:49 PST 2015


ruiu added inline comments.

================
Comment at: test/ELF/emulation.s:167-173
@@ +166,9 @@
+# AARCH64-NEXT:   ]
+# AARCH64-NEXT:   HeaderSize: 64
+# AARCH64-NEXT:   ProgramHeaderEntrySize: 56
+# AARCH64-NEXT:   ProgramHeaderCount:
+# AARCH64-NEXT:   SectionHeaderEntrySize: 64
+# AARCH64-NEXT:   SectionHeaderCount:
+# AARCH64-NEXT:   StringTableSectionIndex:
+# AARCH64-NEXT: }
+
----------------
ikudrin wrote:
> ruiu wrote:
> > Remove these lines as the other test cases doesn't test these fields.
> As far as I can see, both X86-64 and PPC64 have the same lines, X86 has similar lines and only MIPS and MIPSEL miss them.
Then maybe we should remove from them too? I think the purpose of this test is to test is Machine field, so checking values of miscellaneous Size fields seem excessive.


http://reviews.llvm.org/D14831





More information about the llvm-commits mailing list