[PATCH] [WebAssembly] rewrite argument unscheduling loop

[Dan Gohman via llvm-commits]

Hi Eric,

Yeah, looks ok to me. Thanks for fixing this!

As the comment says, I'm hoping to remove that code soon anyway;
http://reviews.llvm.org/D14750 is what I'm currently hoping to do instead.

Dan


On Thu, Nov 19, 2015 at 4:24 PM, Eric Christopher <echristo at gmail.com>
wrote:

> Hi Dan, JF,
>
> I was getting a weird memory iterator error in this loop (in ToT with
> Debug+Asserts), but while I was looking at it I realized we could simplify
> the logic a bit if we split the loop apart into two - the part looking for
> the new insert point and then the part to look for all of the argument
> instructions.
>
> It also solves the problem I was seeing with an invalid EntryBB.begin()
> during the insert.
>
> OK?
>
> -eric
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151119/6c6291a9/attachment.html>