[PATCH] D14830: [html] Advertize the charset actually being used. NFC.

Arnaud A. de Grandmaison via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 10:23:07 PST 2015


aadg created this revision.
aadg added reviewers: cmatthews, ddunbar.
aadg added a subscriber: llvm-commits.

We currently advertize the ISO-8859-1 charset is used when we
actually use UTF-8. Let's be consistent an advertize the truth.

This is the last patch in a serie which has brought the main, machine, run and
daily_report pages into clean html (according to https://validator.w3.org/nu).

I'm however wondering if there were any reason to use ISO-8859-1, thus this request for review.

http://reviews.llvm.org/D14830

Files:
  lnt/server/ui/templates/layout.html

Index: lnt/server/ui/templates/layout.html
===================================================================
--- lnt/server/ui/templates/layout.html
+++ lnt/server/ui/templates/layout.html
@@ -1,6 +1,7 @@
 <!DOCTYPE html>
 <html lang="en">
 <head>
+  <meta charset="UTF-8"/>
   <link href="{{ url_for('.static', filename='bootstrap/css/bootstrap.min.css')
               }}" rel="stylesheet" media="screen"/>
   <link href="{{ url_for('.static', filename='bootstrap/css/bootstrap-responsive.min.css')
@@ -23,12 +24,12 @@
   <link rel="stylesheet" type="text/css" href="//cdn.datatables.net/1.10.8/css/jquery.dataTables.css" />
                  
    <!-- DataTables -->
-   <script type="text/javascript" charset="utf8" src="//cdn.datatables.net/1.10.8/js/jquery.dataTables.js">
+   <script type="text/javascript" charset="UTF-8" src="//cdn.datatables.net/1.10.8/js/jquery.dataTables.js">
    </script>
 
 
   <meta name="viewport" content="width=device-width, initial-scale=1.0"/>
-  <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1"/>
+  <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
 
   <style type="text/css">
     /* Sticky footer styles ------------------------------------------------- */


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14830.40673.patch
Type: text/x-patch
Size: 1244 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151119/7b33933b/attachment.bin>


More information about the llvm-commits mailing list