[PATCH] D14791: [asan] On OS X, write error reports into Crash Report.

[Alexander Potapenko via llvm-commits]

glider accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: lib/sanitizer_common/sanitizer_mac.h:45
@@ +44,3 @@
+  &__crashreporter_info_buff__[0];
+asm(".desc ___crashreporter_info__, 0x10");
+} // extern "C"
----------------
kubabrecka wrote:
> glider wrote:
> > kubabrecka wrote:
> > > glider wrote:
> > > > According to http://lists.apple.com/archives/cocoa-dev/2013/Feb/msg00612.html and http://lists.apple.com/archives/cocoa-dev/2013/Feb/msg00613.html this isn't going to work on iOS, right?
> > > That's correct, the iOS Crash Reporter intentionally doesn't include additional application-provided information in the crash logs.
> > So don't we want to hide these bits behind "#if !SANITIZER_IOS" ?
> The code still works for iOS simulator, and if we keep if unconditionally, then if a future iOS version starts including this in crash logs, we'd automatically benefit from that.
> 
> But I'm fine with `#if !SANITIZER_IOS && !SANITIZER_IOSSIM`, if you prefer that.
No, I just was under the impression that we may get linker errors on iOS.
I'm fine with the current implementation.


http://reviews.llvm.org/D14791