[PATCH] D14183: [AArch64]Extend merging narrow loads into a wider load

Jun Bum Lim via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 07:58:40 PST 2015


junbuml added a comment.

Thanks James and Chad for the review!


================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:616
@@ -566,1 +615,3 @@
 
+    int width = getMemScale(I) == 1 ? 8 : 16;
+    int lsbLow = 0;
----------------
mcrosier wrote:
> In general, variable names should begin with a capital letter and are written in camel case.
> 
> width -> Width
> lsbLow -> LSBLow or LsbLow
> lsbHigh -> LSBHigh or LsbHigh
> immsLow -> ImmsLow
> immsHigh -> ImmsHigh
Oh. Yes. I will fix it !


http://reviews.llvm.org/D14183





More information about the llvm-commits mailing list