[PATCH] D14789: libc++abi: mark visibility

Jonathan Roelofs via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 07:21:19 PST 2015


jroelofs added inline comments.

================
Comment at: include/__cxxabi_config.h:24
@@ +23,3 @@
+
+#if defined(LIBCXXABI_DLL)
+ #if defined(cxxabi_EXPORTS)
----------------
compnerd wrote:
> jroelofs wrote:
> > s/LIBCXXABI_DLL/_LIBCXXABI_DLL/
> Sure, though the thing is that this would be different from libc++, which uses `LIBCPP_DLL`.
Two wrongs don't make a right...


http://reviews.llvm.org/D14789





More information about the llvm-commits mailing list