[PATCH] D14778: [PPC64] Enable shrink wrapping for PPC64 LE.

Kit Barton via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 07:17:20 PST 2015


kbarton added inline comments.

================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:585
@@ +584,3 @@
+
+    if (MBBI != MBB->begin())
+      RS.forward(MBBI);
----------------
qcolombet wrote:
> You still need to check that “begin” is not the terminator, otherwise, you’ll get the available register after the terminator, not before.
Maybe I misunderstand, but this check should cover that. 
MBBI is initialized to MBB->getFirstTerminator() above, so the iterator will not move forward if begin is the terminator. 


http://reviews.llvm.org/D14778





More information about the llvm-commits mailing list