[PATCH] D14803: [AArch64] Fix a corner case in BitFeild select

[James Molloy via llvm-commits]

jmolloy added a subscriber: jmolloy.
jmolloy accepted this revision.
jmolloy added a reviewer: jmolloy.
jmolloy added a comment.
This revision is now accepted and ready to land.

This LGTM, Thanks!


================
Comment at: lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:1700
@@ +1699,3 @@
+  // trivially true.
+  if (BitWidth == 0)
+    return true;
----------------
mgrang wrote:
> Can we change this to if (!BitWidth) ?
I don't agree with this, BitWidth is an integer, not a boolean. "== 0" expresses the intent better than !.


http://reviews.llvm.org/D14803