[PATCH] D14775: [FunctionAttrs] Provide a mechanism for adding function attributes from the command line

[Akira Hatanaka via llvm-commits]

I was thinking about implementing the mechanism to add function attributes
in llvm/CodeGen/CommandFlags.h so that both llc and opt can benefit from it
and we don't have to rely on funcattrs to add attributes. The downside is
that we won't be able to remove attributes from clang's command line.

On Wed, Nov 18, 2015 at 8:42 AM, James Molloy <james at jamesmolloy.co.uk>
wrote:

> Hi Akira,
>
> This will be useful whenever functionattrs is run; this includes clang but
> not, I think, llc.
>
> I considered adding an option to remove attributes, but I decided against
> it. Adding an attribute is easy - attributes are almost never removed
> during compilation (apart from inlining). However attributes are regularly
> inferred, so I could really make no guarantee about the effectiveness of
> removing a function attribute (as it may be re added later!)
>
> James
> On Wed, 18 Nov 2015 at 15:55, Akira Hatanaka via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> ahatanak added a subscriber: ahatanak.
>> ahatanak added a comment.
>>
>> Will this command line option be useful for llc or other tools too? Also,
>> an option to remove the attributes from a function might be useful too.
>>
>>
>> Repository:
>>   rL LLVM
>>
>> http://reviews.llvm.org/D14775
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151118/115e9b68/attachment.html>