[PATCH] D14713: [ELF2] - Optimization for R_X86_64_GOTTPOFF relocation.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/InputSection.cpp:150
@@ -149,1 +149,3 @@
       continue;
+    } else if (Body.isTLS() && Target->getTlsOptimization(Type, Body)) {
+      Target->relocateTlsOptimize(BufLoc, Buf, BufEnd, Type, AddrLoc,
----------------
getTlsOptimization -> isTlsOptimized (since it returns a boolean value.)

Can you move this before

  uintX_t SymVA = getSymVA<ELFT>(Body);

?

================
Comment at: ELF/InputSection.cpp:151
@@ +150,3 @@
+    } else if (Body.isTLS() && Target->getTlsOptimization(Type, Body)) {
+      Target->relocateTlsOptimize(BufLoc, Buf, BufEnd, Type, AddrLoc,
+                                  SymVA);
----------------
Currently you are not using BufEnd, so please remove that parameter.

================
Comment at: ELF/Target.cpp:354
@@ +353,3 @@
+    return false;
+  return (Type == R_X86_64_GOTTPOFF && !canBePreempted(&S, true));
+}
----------------
Remove outermost ().

================
Comment at: ELF/Target.cpp:371-372
@@ +370,4 @@
+                                           uint64_t P, uint64_t SA) const {
+  if (Loc - 3 < BufStart)
+    error("Tls relocation optimization fail, buffer overrun !");
+  uint8_t *Prefix = &Loc[-3];
----------------
I'm wondering if this is correct. One should never use a R_X86_64_GOTTPOFF relocation with instructions other than MOV or ADD?


http://reviews.llvm.org/D14713