[compiler-rt] r253489 - [PGO] Removed an extra ')' in the LLVM_ALIGNAS(x) macro.

[Betul Buyukkurt via llvm-commits]

Hi Bruno, 

I tried to fix it in rev 253492. Waiting for the build bots. However, I just realized that I bypassed the code review. Realized after submitting it. Will watch out next time.

Thanks,
-Betul

-----Original Message-----
From: Bruno Cardoso Lopes [mailto:bruno.cardoso at gmail.com] 
Sent: Wednesday, November 18, 2015 11:40 AM
To: Betul Buyukkurt
Cc: llvm-commits
Subject: Re: [compiler-rt] r253489 - [PGO] Removed an extra ')' in the LLVM_ALIGNAS(x) macro.

Hi Betul,

This broke the bot:
http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_build/14513/

In file included from
/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib/profile/InstrProfiling.c:10:
/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib/profile/InstrProfiling.h:54:31:
error: expected ')'
typedef struct LLVM_ALIGNAS(8) __llvm_profile_data {
                              ^
                              )
/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib/profile/InstrProfiling.h:54:9:
error: declaration of anonymous struct must be a definition typedef struct LLVM_ALIGNAS(8) __llvm_profile_data {
        ^
/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib/profile/InstrProfiling.h:54:1:
error: typedef requires a name [-Werror,-Wmissing-declarations] typedef struct LLVM_ALIGNAS(8) __llvm_profile_data { ^~~~~~~
  COMPILE:   clang_darwin/cc_kext/i386:
/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib/builtins/absvsi2.c
/Users/buildslave/jenkins/sharedspace/phase1 at 2/clang-build/Release+Asserts/bin/clang
-fPIC -I/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib
-I/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/include
-arch i386 -fvisibility=hidden -DVISIBILITY_HIDDEN -mkernel -DKERNEL_USE -Wall -Werror -O3 -fomit-frame-pointer
-mmacosx-version-min=10.4 -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk
-c -o /Users/buildslave/jenkins/sharedspace/phase1 at 2/clang-build/tools/clang/runtime/compiler-rt/clang_darwin/cc_kext/i386/SubDir.lib__builtins/absvsi2.o
/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib/builtins/absvsi2.c
/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib/profile/InstrProfiling.h:97:7:
error: unknown type name '__llvm_profile_data'; did you mean '__llvm_profile_header'?
const __llvm_profile_data *__llvm_profile_begin_data(void);
      ^~~~~~~~~~~~~~~~~~~
      __llvm_profile_header
/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib/profile/InstrProfiling.h:76:3:
note: '__llvm_profile_header' declared here } __llvm_profile_header;
  ^
/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib/profile/InstrProfiling.h:98:7:
error: unknown type name '__llvm_profile_data'; did you mean '__llvm_profile_header'?
const __llvm_profile_data *__llvm_profile_end_data(void);
      ^~~~~~~~~~~~~~~~~~~
      __llvm_profile_header
/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib/profile/InstrProfiling.h:76:3:
note: '__llvm_profile_header' declared here } __llvm_profile_header;
  ^
In file included from
/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib/profile/InstrProfilingBuffer.c:10:
/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/compiler-rt/lib/profile/InstrProfiling.h:54:31:
error: expected ')'
typedef struct LLVM_ALIGNAS(8) __llvm_profile_data {
                              ^
                              )

On Wed, Nov 18, 2015 at 11:11 AM, Betul Buyukkurt via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> Author: betulb
> Date: Wed Nov 18 13:11:31 2015
> New Revision: 253489
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253489&view=rev
> Log:
> [PGO] Removed an extra ')' in the LLVM_ALIGNAS(x) macro.
>
>
> Modified:
>     compiler-rt/trunk/lib/profile/InstrProfiling.h
>
> Modified: compiler-rt/trunk/lib/profile/InstrProfiling.h
> URL: 
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/profile/Inst
> rProfiling.h?rev=253489&r1=253488&r2=253489&view=diff
> ======================================================================
> ========
> --- compiler-rt/trunk/lib/profile/InstrProfiling.h (original)
> +++ compiler-rt/trunk/lib/profile/InstrProfiling.h Wed Nov 18 13:11:31 
> +++ 2015
> @@ -13,7 +13,7 @@
>  #ifdef _MSC_VER
>  # define LLVM_ALIGNAS(x) __declspec(align(x))  #elif __GNUC__ && 
> !__has_feature(cxx_alignas) -# define LLVM_ALIGNAS(x) 
> __attribute__((aligned(x)))
> +# define LLVM_ALIGNAS(x) __attribute__((aligned(x))
>  #else
>  # define LLVM_ALIGNAS(x) alignas(x)
>  #endif
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



--
Bruno Cardoso Lopes
http://www.brunocardoso.cc