[PATCH] D14719: Track pristine registers in terms of register units.

Krzysztof Parzyszek via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 07:25:48 PST 2015


On 11/17/2015 5:11 PM, Matthias Braun wrote:
> I must admit I still don't understand why you can't just put R16+R17 instead of D8 into the CSI set.

There is no hard reason why we wouldn't be able to do that.  It's just 
that the entire logic of coalescing registers into pairs and assigning 
the stack locations is now done in one place.  If we kept individual 
registers in CSI, the coalescing would need to happen in the code that 
generates the actual save/restore instructions.

If the expectations regarding getCalleeSavedRegs and CSI are formalized, 
I don't have a problem changing the Hexagon code to conform.


> In any way I can live with iterating over subregs in getPristineRegs().

Ok, let me do that for now.  We can always revisit it later.


-Krzysztof


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation


More information about the llvm-commits mailing list