[PATCH] D14755: Handle ARMv6-J as an alias, instead of fake architecture

[Renato Golin via llvm-commits]

rengolin added reviewers: joerg, jroelofs, t.p.northover.
rengolin added subscribers: jroelofs, joerg, t.p.northover.
rengolin added a comment.

I'm ok with the change, but I'd rather hear from @joerg, @compnerd, @t.p.northover, @jroelofs to make sure we're not breaking anything.

cheers,
--renato


================
Comment at: unittests/ADT/TripleTest.cpp:855
@@ -854,3 +854,3 @@
     llvm::Triple Triple("armv6j-unknown-eabi");
-    EXPECT_EQ("arm1136j-s", Triple.getARMCPUForArch());
+    EXPECT_EQ("arm1136jf-s", Triple.getARMCPUForArch());
   }
----------------
Non-functional triples were recorded because of the default CPU they had more than what they actually meant. In this case, the difference is between having VFP or not, which makes a huge difference on soft vs hard float and could wreak havoc on build systems.

I'm not saying that it's a good idea to keep the unknown legacy, but we gotta at least give some thought to this change.


http://reviews.llvm.org/D14755