[PATCH] D14759: In TargetParser, disallow duplicate CPU names. (NFC)

[Renato Golin via llvm-commits]

rengolin requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: lib/Support/TargetParser.cpp:106
@@ -105,6 +105,3 @@
 
 // List of CPU names and their arches.
 // FIXME: TableGen this.
----------------
Removing the comment without addressing the problem is not a fix.

================
Comment at: lib/Support/TargetParser.cpp:577
@@ +576,3 @@
+
+// ======================================================= //
+// Make sure all names are unique and non-empty
----------------
I'd rather move to table-gen, which can guarantee correctness in the table-gen back-end, than adding this code.


http://reviews.llvm.org/D14759