[PATCH] D14757: Handle ARMv7K as an alias, instead of fake architecture (NFC)

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 03:48:02 PST 2015


rengolin requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: lib/Target/ARM/ARMSubtarget.cpp:156
@@ -154,3 +155,3 @@
   UseSjLjEH = (isTargetDarwin() &&
-               TargetTriple.getSubArch() != Triple::ARMSubArch_v7k);
+               !TargetTriple.getArchName().endswith("v7k"));
 }
----------------
I strongly oppose to going back to string parsing all over the place.

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp:1053
@@ +1052,3 @@
+    StringRef Arch = TheTriple.getArchName();
+    MachO::CPUSubTypeARM CS = (Arch == "armv7k" || Arch == "thumbv7k")
+                              ? MachO::CPU_SUBTYPE_ARM_V7K
----------------
Idem.


http://reviews.llvm.org/D14757





More information about the llvm-commits mailing list