[PATCH] D14698: [tsan] Implement "%env_tsan_opts" substitution to inherit default TSAN_OPTIONS

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 16:14:37 PST 2015


samsonov added inline comments.

================
Comment at: test/tsan/deadlock_detector_stress_test.cc:3
@@ -4,1 +2,3 @@
+// RUN: %env_tsan_opts=detect_deadlocks=1 %deflake %run %t | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-NOT-SECOND
+// RUN: %env_tsan_opts="detect_deadlocks=1 second_deadlock_stack=1" %deflake %run %t | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-SECOND
 // RUN: %clangxx_tsan %s -o %t -DLockType=PthreadSpinLock
----------------
remove quotes and use `:` as a delimiter here.

================
Comment at: test/tsan/fork_atexit.cc:1
@@ -1,2 +1,2 @@
-// RUN: %clangxx_tsan -O1 %s -o %t && TSAN_OPTIONS="atexit_sleep_ms=50" %run %t 2>&1 | FileCheck %s
+// RUN: %clangxx_tsan -O1 %s -o %t && %env_tsan_opts="atexit_sleep_ms=50" %run %t 2>&1 | FileCheck %s
 // UNSUPPORTED: darwin
----------------
same here (and below)


http://reviews.llvm.org/D14698





More information about the llvm-commits mailing list