[PATCH] D10825: Improvement on computing edge probabilities when choosing the best successor in machine block placement.

David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 13:26:42 PST 2015


davidxl added a comment.

Looks fine to me with some nits. It might be better to hold off this until the BP interface change is done?


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:373
@@ +372,3 @@
+    bool SkipSucc = false;
+    if (BlockFilter && !BlockFilter->count(Succ)) {
+      SkipSucc = true;
----------------
Can you add your example as a comment in the code?


http://reviews.llvm.org/D10825





More information about the llvm-commits mailing list