[PATCH] D14668: [WinEH] Move WinEHFuncInfo from MachineModuleInfo to MachineFunction

Joseph Tremoulet via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 07:58:53 PST 2015


JosephTremoulet added a comment.

> WinEHFuncInfo is not a good name for our bag of EH data structures. EHFuncletInfo? EHFuncletStates? EHFuncletTables?


I don't feel too strongly here, but

- I like "_Info" since, as you say, it's a bag of data structures, and suffixing such things with Info seems to be fairly common in LLVM
- I like the term "Funclet EH" as a generic replacement for "Windows EH".

So something like:

- WinEHFuncInfo -> FuncletEHInfo
- WinEHStatePass -> FuncletEHStatePass
- WinEHHandlerType -> ??? This one is just used for C++, right?  MSVCXXHandlerType?
- WinEHTryBlockMapEntry -> FuncletTryMapEntry (dropped "EH" and "Block" just because it's such a mouthful)
- WinEHPrepare -> FuncletEHPrepare (though since this does now just get invoked for Windows targets, it may make sense to leave its name alone until that changes)

?


http://reviews.llvm.org/D14668





More information about the llvm-commits mailing list