[llvm] r253331 - [ARM] Properly initialize ARMArch in the ARM subtarget

Bradley Smith via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 05:39:20 PST 2015


> Subject: Re: [llvm] r253331 - [ARM] Properly initialize ARMArch in the
> ARM subtarget
> 
> On 17 November 2015 at 11:57, Bradley Smith via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > -    ARMv2, ARMv2a, ARMv3, ARMv3m, ARMv4, ARMv4t, ARMv5, ARMv5t,
> ARMv5te,
> > +    Other, ARMv2, ARMv2a, ARMv3, ARMv3m, ARMv4, ARMv4t, ARMv5,
> ARMv5t, ARMv5te,
> 
> Hi Bradley,
> 
> We were explicitly *not* setting an invalid/other tag, as we want to
> continue the behaviour of emitting the lowest common denominator
> supported (armv4t) when no architecture is mentioned.
> 
> I think it's safe to assume ARMv4T here instead of "Other", unless
> your generic CPU/Arch changes already transform Other into ARMv4T.

Yea, I think you're right, I'll remove Other and put in ARMv4T here.

Regards,
Bradley Smith




More information about the llvm-commits mailing list