[PATCH] D14547: [llvm-profdata] Add support for weighted merge of profile data

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 19:11:59 PST 2015


silvas added inline comments.

================
Comment at: tools/llvm-profdata/llvm-profdata.cpp:155
@@ +154,3 @@
+      // Input weight specified.
+      uint64_t weight;
+      if (splitInput.second.getAsInteger(10, weight) || weight < 1) {
----------------
http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
(here and doublecheck elsewhere)

================
Comment at: tools/llvm-profdata/llvm-profdata.cpp:158
@@ +157,3 @@
+        // Invalid input weight.
+        exitWithError("Input weight must be a postive integer.");
+      }
----------------
typo "postive"


http://reviews.llvm.org/D14547





More information about the llvm-commits mailing list