[PATCH] D14480: Improve running time of getAsmSrcLocInfo

Yunlian Jiang via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 16:34:45 PST 2015


yunlian added inline comments.

================
Comment at: lib/AST/Expr.cpp:1030
@@ +1029,3 @@
+  unsigned StringOffset = 0;
+  if (StartToken) TokNo = *StartToken;
+  if (StartTokenByteOffset) {
----------------
yunlian wrote:
> rafael wrote:
> > This part also needs git-clang-format..
> Which part? Could you please give me some advice on how to modify it?
> Thanks
> I run git clang-format and it says clang-format did not modify any files.
> 
For this line:
if (StartToken) TokNo = *StartToken;

I try to make it like
if (StartToken)
  TokNo = *StartToken;  

Bug git clang-format changes it back.


http://reviews.llvm.org/D14480





More information about the llvm-commits mailing list