[PATCH] D14706: [lit] Implement support of per test timeout in lit.

[Dan Liew via llvm-commits]

delcypher marked an inline comment as done.

================
Comment at: utils/lit/lit/main.py:477
@@ -451,1 +476,3 @@
+                      ('Unexpected Failures', lit.Test.FAIL),
+                      ('Individual timeouts', lit.Test.TIMEOUT)):
         if opts.quiet and not code.isFailure:
----------------
jroelofs wrote:
> s/timeouts/Timeouts/
Will fix.

================
Comment at: utils/lit/tests/Inputs/googletest-timeout/DummySubDir/OneTest:31
@@ +30,3 @@
+elif test_name == 'FirstTest.subTestC':
+    print('I am subTest B, I will hang')
+    while True:
----------------
jroelofs wrote:
> copy-pasta? s/subtest B/subtest C/
Oops yes that's  a mistake.

================
Comment at: utils/lit/tests/lit.cfg:53
@@ +52,2 @@
+except ImportError:
+    lit_config.warning('Could not import psutil. Some tests will be skipped')
----------------
jroelofs wrote:
> I'd make a note that `--timeout` functionality will be disabled too.
I'll make a note of it.

================
Comment at: utils/lit/tests/shtest-timeout.py:12
@@ +11,3 @@
+
+# CHECK-EXTSH-OUT: TIMEOUT: per_test_timeout :: infinite_loop.py
+# CHECK-EXTSH-OUT: PASS: per_test_timeout :: short.py
----------------
jroelofs wrote:
> I think you only need one set of CHECK lines after the three sets of RUN lines. Since the only part that's different is the ERR output, only those checks need to be duplicated/specialized.
That's a good idea. I'll do that.


http://reviews.llvm.org/D14706