[PATCH] D14721: patch for missed constantFold optimization in InstCombine

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 15:00:35 PST 2015


majnemer added a comment.

In http://reviews.llvm.org/D14721#290480, @optimusPrime wrote:

> In http://reviews.llvm.org/D14721#290414, @majnemer wrote:
>
> > This needs a test case.  Also, you need to upload a diff with more context. There are instructions here <http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface> on how to do this.
>
>
> Hi David,
>  I have already attached a test case in the summary section. Isn't that sufficient ?


It should be part of the patch.


http://reviews.llvm.org/D14721





More information about the llvm-commits mailing list