[PATCH] D14231: [Support] Use GetTempDir to get the temporary dir path on Windows.

[Aaron Ballman via llvm-commits]

aaron.ballman added a comment.

In http://reviews.llvm.org/D14231#290061, @chfast wrote:

> It turned out Windows 7 is affected by 130 bytes env var issue. Windows 8 is fine. Sorry for not checking that correctly in the first place as I was supposed to do.
>
> In other words Windows 7 fails unit tests that check 260 char length paths. It there any way we can still safe this patch?


I'm not certain that we should. When we drop support for Windows 7, then this would obviously be a good patch to bring back. However, in the interim, it may make sense to use the existing code perform the operations we were getting for free with GetTempPath (making separators native (\), making the path absolute, etc.). All of your unit tests are still great, of course.


Repository:
  rL LLVM

http://reviews.llvm.org/D14231