[PATCH] D14711: fix lldb crash by changing const char * with StringRef

[Eugene Kosov via llvm-commits]

Hello.

Here is the description of a crash http://lists.llvm.org/pipermail/llvm-dev/2015-November/092429.html

I thinks its testable. Option::ArgStr, Option::HelpStr, Option::ValueStr must not be nullptr. We could make them private and put assertions in setter function. And test it. StringRef can not be created from nullptr string.

16.11.2015, 20:38, "David Blaikie" <dblaikie at gmail.com>:
> What's the actual bug in LLDB's usage & how does this address it? Is it testable in LLVM? (unit tests?)
>
> On Mon, Nov 16, 2015 at 9:26 AM, Eugene via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> kevgs created this revision.
>> kevgs added a reviewer: llvm-commits.
>> kevgs added a subscriber: llvm-commits.
>> kevgs set the repository for this revision to rL LLVM.
>>
>> Description: http://lists.llvm.org/pipermail/llvm-dev/2015-November/092429.html
>>
>> Repository:
>>   rL LLVM
>>
>> http://reviews.llvm.org/D14711
>>
>> Files:
>>   include/llvm/Support/CommandLine.h
>>   lib/Support/CommandLine.cpp
>>   unittests/Support/CommandLineTest.cpp
>>   utils/FileCheck/FileCheck.cpp
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

--
Eugene