[PATCH] D9009: Value profiling compiler-rt changes

[Betul Buyukkurt via llvm-commits]

I’ll be posting the clang patches for IC profiling soon and will add tests along w/ the changes. That might also be a good way to test the feature.

 

-Betul

 

From: Xinliang David Li [mailto:davidxl at google.com] 
Sent: Sunday, November 15, 2015 10:15 PM
To: reviews+D9009+public+928a0f9fb6abdd51 at reviews.llvm.org
Cc: Betul Buyukkurt; Justin Bogner; Bob Wilson; Diego Novillo; cvick at codeaurora.org; llvm-commits
Subject: Re: [PATCH] D9009: Value profiling compiler-rt changes

 

LGTM.

 

(Note: I expect there will be a period of time when the value profiling feature is still experimental, and  the raw format will be under further changing/tuning before it settles down).

 

thanks,

 

David

 

On Sun, Nov 15, 2015 at 9:52 PM, Betul Buyukkurt <betulb at codeaurora.org <mailto:betulb at codeaurora.org> > wrote:

betulb updated this revision to Diff 40248.
betulb added a comment.

In this revision:

- Add definition and use for the LLVM_ALIGNAS(x) macro to set the alignment for __llvm_profile_data struct in InstrProfiling.h



http://reviews.llvm.org/D9009

Files:
  lib/profile/InstrProfiling.c
  lib/profile/InstrProfiling.h
  lib/profile/InstrProfilingBuffer.c
  lib/profile/InstrProfilingFile.c

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151115/9210a652/attachment.html>