[PATCH] D14331: [X86][AVX512] add comi with Sae

[Elena Demikhovsky via llvm-commits]

delena added inline comments.

================
Comment at: ../commit/llvm_clean/lib/Target/X86/X86ISelLowering.cpp:16434
@@ -16433,3 +16433,3 @@
       SDValue RHS = Op.getOperand(2);
       unsigned X86CC = TranslateX86CC(CC, dl, true, LHS, RHS, DAG);
       assert(X86CC != X86::COND_INVALID && "Unexpected illegal condition!");
----------------
X86CC - unsigned
X86CC - a tuple, please use another name in the next case

================
Comment at: ../commit/llvm_clean/lib/Target/X86/X86ISelLowering.cpp:16447
@@ +16446,3 @@
+      auto X86CC = TranslateX86ConstCondToX86CC(CC);
+      unsigned comiOp = std::get<0>(X86CC) ? IntrData->Opc0 : IntrData->Opc1;
+      SDValue Cond;
----------------
Please add comments here.

================
Comment at: ../commit/llvm_clean/lib/Target/X86/X86ISelLowering.cpp:16450
@@ +16449,3 @@
+      if (cast<ConstantSDNode>(Sae)->getZExtValue() !=
+                          X86::STATIC_ROUNDING::CUR_DIRECTION)
+        Cond = DAG.getNode(comiOp, dl, MVT::i32, LHS, RHS, Sae);
----------------
Align the line

================
Comment at: ../commit/llvm_clean/lib/Target/X86/X86IntrinsicsInfo.h:1811
@@ -1808,1 +1810,3 @@
 
+// X86 specific compare constants.
+// They must be kept in synch with avxintrin.h
----------------
It may fail on platforms, where these constants are defined.


http://reviews.llvm.org/D14331